Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Maintainer Checklist: add guidelines for members #6416

Merged
merged 1 commit into from
Sep 4, 2019
Merged

New Maintainer Checklist: add guidelines for members #6416

merged 1 commit into from
Sep 4, 2019

Conversation

jonchang
Copy link
Contributor

@jonchang jonchang commented Sep 3, 2019

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Maintainers should generally be members, so add that to the checklist. Also add a checklist for new members, so they're properly recorded in all the places they ought to be.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @jonchang!

@jonchang jonchang merged commit f0f4142 into Homebrew:master Sep 4, 2019
@jonchang jonchang deleted the members branch September 4, 2019 09:31
@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants